Open
Conversation
sdharav
commented
Jan 18, 2026
sdharav
commented
- Implement Multi-Stage Docker build to compile 'daft' from source using Rust and Bun.
- Optimize build by disabling isolation and filtering requirements to prevent 'git' errors in slim image.
- Modernize infrastructure by moving to MavenCentral and updating scalafmt.
- Fix gradle/docker.gradle to correctly handle space-separated build arguments and flags.
- Update .travis.yml for automated Python 3.11 publishing.
logwolvy
reviewed
Jan 19, 2026
logwolvy
left a comment
logwolvy
left a comment
There was a problem hiding this comment.
The change branch should base off of nimbella:dev.
| # Disabling build isolation forces pip to use the Rust/Bun toolchains we installed above, | ||
| # cutting hours off the build time and preventing redundant toolchain downloads. | ||
| RUN pip install --no-cache-dir maturin pyarrow>=8.0.0 \ | ||
| && pip wheel --no-cache-dir --no-build-isolation --wheel-dir /wheels git+https://github.com/Eventual-Inc/Daft.git@v0.4.8 |
There was a problem hiding this comment.
If daft is not available in pypi, we need not build daft from source, we can pull it from https://github.com/Eventual-Inc/Daft/releases (please verify if this is the correct source).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.